Adds fuchsia node roles to accessibility bridge updates. #20385

abrush21 · 2020-08-10T20:45:54Z

Description

This change adds a semantics flag to mark slider UI elements, and modifies the fuchsia accessibility bridge to populate the fuchsia node role.

Related Issues

N/A

Tests

I added the following tests:

Accessibility bridge unit test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

chunhtai · 2020-08-11T20:23:12Z

it looks like there are tests in framework side that grab all the possible flag from ui.SemanticsFlags and compare it with semantics property api. This create a circular dependencies.

cc @gaaclarke Do you know how should we migrate in this case?

gaaclarke · 2020-08-12T17:32:25Z

@abrush21 Heads up, this PR is failing because you need to run the code through the formatter.

chunhtai · 2020-08-12T17:44:01Z

@abrush21 We will probably need to do a three phase transition regarding the test breakage

fortunately, there are only two tests that are failing

create a framework pr to disable those 2 tests
flutter/packages/flutter/test/widgets/custom_painter_test.dart: CustomPainter Supports all flags
flutter/packages/flutter/test/widgets/semantics_test.dart: Semantics widget supports all flags
land this pr( after fixing the format error)
land the framework pr and enable those 2 tests again.

abrush21 · 2020-08-12T17:44:27Z

I see that issue, and I also see a separate issue in the build_and_test_linux_unopt_debug check that Chun-Heng mentioned. A couple of framework tests (in packages/flutter/test/widgets/semantics_test.dart and flutter/packages/flutter/test/widgets/custom_painter_test.dart) are failing because of the newly introduced semantics flag. https://api.cirrus-ci.com/v1/task/5696073467428864/logs/test_framework.log. Correct me if I'm wrong, but it looks like there's a circular dependency between this change and those tests -- in order to fix the framework tests, the engine change introducing the new flag needs to land, but in order to land the engine change, the framework tests need to pass.

abrush21 · 2020-08-12T17:55:11Z

@chunhtai Sounds good. When you say "disable" those tests, can I just comment the failing tests out in the test files? Or is there a more formal process for enabling/disabling flutter tests?

gaaclarke · 2020-08-12T17:58:05Z

@abrush21 Since this should only exist for a short amount of time I'd say commenting them out is fine. Add a link to the issue and some context at the beginning of the comment.

abrush21 · 2020-09-01T18:47:45Z

@chunhtai @gaaclarke PR 63595 (disabling failing tests) has merged, so this PR is ready for review again.

chunhtai · 2020-09-01T18:57:00Z

lib/ui/semantics.dart

  static const int _kIsReadOnlyIndex = 1 << 20;
  static const int _kIsFocusableIndex = 1 << 21;
  static const int _kIsLinkIndex = 1 << 22;
+  static const int _kIsSliderIndex = 1 << 23;


I think we forgot to mention, we also need to update flutter/lib/web_ui/lib/src/ui/semantics.dart

Can you also modify the comment here to also mention this file?

as well as flutter/shell/platform/android/io/flutter/view/AccessibilityBridge.java line 1748

Sure, done.

chunhtai

LGTM

…tter/engine#20385)

flar · 2020-09-02T04:07:58Z

This test is causing failures in the engine roll (tested by running the test multiple times on this and the previous engine commit):

00:18 +98 ~1: /tmp/flutter sdk/packages/flutter_test/test/matchers_test.dart: matchesSemanticsData Can match all semantics flags and actions                                                           
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure object was thrown running a test:
  Expected: has semantics with actions: [
            SemanticsAction:SemanticsAction.tap,
            SemanticsAction:SemanticsAction.longPress,
            SemanticsAction:SemanticsAction.scrollLeft,
            SemanticsAction:SemanticsAction.scrollRight,
            SemanticsAction:SemanticsAction.scrollUp,
            SemanticsAction:SemanticsAction.scrollDown,
            SemanticsAction:SemanticsAction.increase,
            SemanticsAction:SemanticsAction.decrease,
            SemanticsAction:SemanticsAction.showOnScreen,
            SemanticsAction:SemanticsAction.moveCursorForwardByCharacter,
            SemanticsAction:SemanticsAction.moveCursorBackwardByCharacter,
            SemanticsAction:SemanticsAction.setSelection,
            SemanticsAction:SemanticsAction.copy,
            SemanticsAction:SemanticsAction.cut,
            SemanticsAction:SemanticsAction.paste,
            SemanticsAction:SemanticsAction.didGainAccessibilityFocus,
            SemanticsAction:SemanticsAction.didLoseAccessibilityFocus,
            SemanticsAction:SemanticsAction.customAction,
            SemanticsAction:SemanticsAction.dismiss,
            SemanticsAction:SemanticsAction.moveCursorForwardByWord,
            SemanticsAction:SemanticsAction.moveCursorBackwardByWord
          ] with flags: [
            SemanticsFlag:SemanticsFlag.hasCheckedState,
            SemanticsFlag:SemanticsFlag.isChecked,
            SemanticsFlag:SemanticsFlag.isSelected,
            SemanticsFlag:SemanticsFlag.isButton,
            SemanticsFlag:SemanticsFlag.isLink,
            SemanticsFlag:SemanticsFlag.isTextField,
            SemanticsFlag:SemanticsFlag.isReadOnly,
            SemanticsFlag:SemanticsFlag.isFocused,
            SemanticsFlag:SemanticsFlag.isFocusable,
            SemanticsFlag:SemanticsFlag.hasEnabledState,
            SemanticsFlag:SemanticsFlag.isEnabled,
            SemanticsFlag:SemanticsFlag.isInMutuallyExclusiveGroup,
            SemanticsFlag:SemanticsFlag.isHeader,
            SemanticsFlag:SemanticsFlag.isObscured,
            SemanticsFlag:SemanticsFlag.namesRoute,
            SemanticsFlag:SemanticsFlag.scopesRoute,
            SemanticsFlag:SemanticsFlag.isHidden,
            SemanticsFlag:SemanticsFlag.isImage,
            SemanticsFlag:SemanticsFlag.isLiveRegion,
            SemanticsFlag:SemanticsFlag.hasToggledState,
            SemanticsFlag:SemanticsFlag.isToggled,
            SemanticsFlag:SemanticsFlag.hasImplicitScrolling
          ] with rect: Rect.fromLTRB(0.0, 0.0, 10.0, 10.0) with size: Size(10.0, 10.0) with
elevation: 3.0 with thickness: 4.0 with platformViewId: 105 with maxValueLength: 15 with
currentValueLength: 10 with custom actions: [CustomSemanticsAction(7, label:test, hint:null,
action:null)]
  Actual: _FakeSemanticsNode:<_FakeSemanticsNode#1(Rect.fromLTRB(0.0, 0.0, 0.0, 0.0), invisible)>
   Which: flags were: [hasCheckedState, isChecked, isSelected, isButton, isTextField, isFocused,
hasEnabledState, isEnabled, isInMutuallyExclusiveGroup, isHeader, isObscured, scopesRoute,
namesRoute, isHidden, isImage, isLiveRegion, hasToggledState, isToggled, hasImplicitScrolling,
isReadOnly, isFocusable, isLink, isSlider]
When the exception was thrown, this was the stack:
#4      main.<anonymous closure>.<anonymous closure> (file:///tmp/flutter%20sdk/packages/flutter_test/test/matchers_test.dart:565:7)
#5      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:146:29)
<asynchronous suspension>
#6      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart)
#7      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:784:19)
<asynchronous suspension>
#10     TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:764:14)
#11     AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1173:24)
#12     FakeAsync.run.<anonymous closure>.<anonymous closure> (package:fake_async/fake_async.dart:178:54)
#17     withClock (package:clock/src/default.dart:48:10)
#18     FakeAsync.run.<anonymous closure> (package:fake_async/fake_async.dart:178:22)
#23     FakeAsync.run (package:fake_async/fake_async.dart:178:7)
#24     AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1170:15)
#25     testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:138:24)
#26     Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:175:19)
<asynchronous suspension>
#27     Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart)
#32     Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:173:13)
#33     Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:231:15)
#38     Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:228:5)
#39     Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:383:17)
<asynchronous suspension>
#40     Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart)
#45     Invoker._onRun.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:370:9)
#46     Invoker._guardIfGuarded (package:test_api/src/backend/invoker.dart:415:15)
#47     Invoker._onRun.<anonymous closure> (package:test_api/src/backend/invoker.dart:369:7)
#54     Invoker._onRun (package:test_api/src/backend/invoker.dart:368:11)
#55     LiveTestController.run (package:test_api/src/backend/live_test_controller.dart:153:11)
#56     RemoteListener._runLiveTest.<anonymous closure> (package:test_api/src/remote_listener.dart:256:16)
#61     RemoteListener._runLiveTest (package:test_api/src/remote_listener.dart:255:5)
#62     RemoteListener._serializeTest.<anonymous closure> (package:test_api/src/remote_listener.dart:208:7)
#80     _GuaranteeSink.add (package:stream_channel/src/guarantee_channel.dart:125:12)
#81     new _MultiChannel.<anonymous closure> (package:stream_channel/src/multi_channel.dart:159:31)
#85     CastStreamSubscription._onData (dart:_internal/async_cast.dart:85:11)
#119    new _WebSocketImpl._fromSocket.<anonymous closure> (dart:_http/websocket_impl.dart:1145:21)
#127    _WebSocketProtocolTransformer._messageFrameEnd (dart:_http/websocket_impl.dart:338:23)
#128    _WebSocketProtocolTransformer.add (dart:_http/websocket_impl.dart:232:46)
#138    _Socket._onData (dart:io-patch/socket_patch.dart:2044:41)
#147    new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1580:33)
#148    _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1076:14)
(elided 111 frames from dart:async and package:stack_trace)
This was caught by the test expectation on the following line:
  file:///tmp/flutter%20sdk/packages/flutter_test/test/matchers_test.dart line 565
The test description was:
  Can match all semantics flags and actions

)" This reverts commit 58a6207.

)" (#20936) This reverts commit 58a6207.

…tter/engine#20385)

flar · 2020-09-02T22:30:31Z

I didn't see (or don't remember seeing) any other failures that I thought would come from this PR.

flar · 2020-09-02T22:31:23Z

You can check the test results from any of the engine PRs that "mentioned this PR" before my revert...

…tter/engine#20385)

chunhtai · 2020-09-02T22:54:49Z

@flar Thanks!

@abrush21 , it seems like there is one more test you need to disable in the framework in order to merge this PR https://github.com/flutter/flutter/blob/2f96d1f0263dfdaf9f1c8d4f0fa054839342e350/packages/flutter_test/test/matchers_test.dart#L529

…tter/engine#20385)

* 5e54c70 Reland: Enable hybrid composition by default on Android (#20722) (flutter/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (#3) (flutter/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (#20142)" (flutter/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter/engine#20754) * c700479 Revert external size changes to Picture (flutter/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955) * 80f4481 renaming e2e tests to integration (flutter/engine#20954) * 61e057a Clear GL context before Gr context (flutter/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971)

abrush21 · 2020-09-03T18:58:21Z

Sounds good, created pull request flutter/flutter#65194.

…tter/engine#20385)

* 5e54c70 Reland: Enable hybrid composition by default on Android (#20722) (flutter/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (#3) (flutter/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (#20142)" (flutter/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter/engine#20754) * c700479 Revert external size changes to Picture (flutter/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955) * 80f4481 renaming e2e tests to integration (flutter/engine#20954) * 61e057a Clear GL context before Gr context (flutter/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971) * 6e8930b Roll Skia from be72801f29f9 to f8823b572600 (1 revision) (flutter/engine#20973) * 68b7b84 [fuchsia] Send trace events to system tracing on all configurations (flutter/engine#20974) * 3f05b52 Always set the callback during Rasterizer setup (flutter/engine#20976)

* 5e54c70 Reland: Enable hybrid composition by default on Android (flutter#20722) (flutter/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (flutter#3) (flutter/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (flutter#20385)" (flutter/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (flutter#20142)" (flutter/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter/engine#20754) * c700479 Revert external size changes to Picture (flutter/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955) * 80f4481 renaming e2e tests to integration (flutter/engine#20954) * 61e057a Clear GL context before Gr context (flutter/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971)

* 5e54c70 Reland: Enable hybrid composition by default on Android (flutter#20722) (flutter/engine#20864) * 9398717 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908) * 5f49a95 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865) * c4c4f34 Wait for first frame before checking layer tree (flutter/engine#20910) * 0773bf0 Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909) * 8ec8af7 [windows] Add horizontal scroll support (flutter/engine#20668) * 1bd9b8e Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869) * d67923f Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912) * abe10d1 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913) * 101316b [web] migrate from e2e to integration_test (flutter/engine#20914) * 1f52ec3 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917) * 8019058 Default C++ wrapper templates to EncodableValue (flutter/engine#20760) * 5f3ec38 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919) * a651020 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920) * 696c2aa Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924) * 95f2b72 Create root isolate asynchronously (flutter/engine#20142) * 58a6207 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385) * a762143 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928) * 49d6805 Ensure all images are closed in FlutterImageView (flutter/engine#20842) * d67bda7 Image.toByteData and Picture.toImage implementations (flutter#3) (flutter/engine#20750) * 96efe39 Revert "Adds fuchsia node roles to accessibility bridge updates. (flutter#20385)" (flutter/engine#20936) * 5585ed9 Revert "Create root isolate asynchronously (flutter#20142)" (flutter/engine#20937) * f6270c0 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939) * 15bf1bb [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921) * 615e668 Clear the GL context only after submitting the frame (flutter/engine#20931) * ca989b8 Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943) * 8f3f711 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944) * 873c007 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935) * d761629 Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949) * f6920da Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952) * 634e499 Use hint freed specifically for image disposal (flutter/engine#20754) * c700479 Revert external size changes to Picture (flutter/engine#20950) * 4353797 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955) * 80f4481 renaming e2e tests to integration (flutter/engine#20954) * 61e057a Clear GL context before Gr context (flutter/engine#20957) * f43c3d7 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958) * 5a2db33 Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961) * efb339f Only clear GL context after changing the thread configuration (flutter/engine#20965) * 58d5132 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968) * 3729fdb Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969) * 40fe7f3 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970) * e979c29 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971) * 6e8930b Roll Skia from be72801f29f9 to f8823b572600 (1 revision) (flutter/engine#20973) * 68b7b84 [fuchsia] Send trace events to system tracing on all configurations (flutter/engine#20974) * 3f05b52 Always set the callback during Rasterizer setup (flutter/engine#20976)

…es. (flutter#20385)" (flutter#20936)" This reverts commit 96efe39.

…es. (#20385)" (#20936)" (#21367) This reverts commit 96efe39.

googlebot added the cla: yes label Aug 10, 2020

auto-assign bot requested a review from GaryQian August 10, 2020 20:46

abrush21 force-pushed the a11y-roles-2 branch from f7a78dd to 470a18a Compare August 11, 2020 18:01

abrush21 mentioned this pull request Aug 11, 2020

Adds a semantics node flag to identify sliders. flutter/flutter#63524

Closed

13 tasks

abrush21 force-pushed the a11y-roles-2 branch from 470a18a to 5e62d2c Compare August 12, 2020 17:53

abrush21 force-pushed the a11y-roles-2 branch from 5e62d2c to e38fc62 Compare September 1, 2020 17:40

chunhtai reviewed Sep 1, 2020

View reviewed changes

Adds fuchsia node roles to accessibility bridge updates.

5110981

abrush21 force-pushed the a11y-roles-2 branch from e38fc62 to 5110981 Compare September 1, 2020 19:15

chunhtai approved these changes Sep 1, 2020

View reviewed changes

chunhtai added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 1, 2020

fluttergithubbot merged commit 58a6207 into flutter:master Sep 1, 2020

engine-flutter-autoroll mentioned this pull request Sep 1, 2020

Roll Engine from 165abef0a2cb to a76214307e12 (18 revisions) flutter/flutter#65055

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 1, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

170c182

…tter/engine#20385)

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to 49d68053249f (19 revisions) flutter/flutter#65058

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

3359191

…tter/engine#20385)

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to d67bda725ae9 (20 revisions) flutter/flutter#65062

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

e8637b4

…tter/engine#20385)

flar added a commit that referenced this pull request Sep 2, 2020

Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385

8648198

)" This reverts commit 58a6207.

flar mentioned this pull request Sep 2, 2020

Revert "Adds fuchsia node roles to accessibility bridge updates." #20936

Merged

flar added a commit that referenced this pull request Sep 2, 2020

Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385

96efe39

)" (#20936) This reverts commit 58a6207.

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to 5585ed99039e (22 revisions) flutter/flutter#65075

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

4197ec6

…tter/engine#20385)

engine-flutter-autoroll mentioned this pull request Sep 2, 2020

Roll Engine from 165abef0a2cb to 634e499bcc65 (31 revisions) flutter/flutter#65130

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

39bde47

…tter/engine#20385)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 5a2db338e148 (37 revisions) flutter/flutter#65151

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

5b09ae2

…tter/engine#20385)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to efb339f3000d (38 revisions) flutter/flutter#65154

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

06f05ce

…tter/engine#20385)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 58d5132e07e9 (39 revisions) flutter/flutter#65155

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

89b9de1

…tter/engine#20385)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 3729fdb7936d (40 revisions) flutter/flutter#65161

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

69f5853

…tter/engine#20385)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 40fe7f3597b6 (41 revisions) flutter/flutter#65172

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

2bafd90

…tter/engine#20385)

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to e979c29a2a50 (42 revisions) flutter/flutter#65178

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

bf3baa3

…tter/engine#20385)

abrush21 mentioned this pull request Sep 3, 2020

Disables test failing due to new semantics flag. flutter/flutter#65194

Merged

13 tasks

engine-flutter-autoroll mentioned this pull request Sep 3, 2020

Roll Engine from 165abef0a2cb to 3f05b521b939 (45 revisions) flutter/flutter#65196

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2020

58a6207 Adds fuchsia node roles to accessibility bridge updates. (flu…

15999ce

…tter/engine#20385)

abrush21 mentioned this pull request Sep 14, 2020

Adds getter/setter for slider semantics flag. flutter/flutter#65766

Merged

13 tasks

abrush21 added a commit to abrush21/engine that referenced this pull request Sep 23, 2020

Revert "Revert "Adds fuchsia node roles to accessibility bridge updat…

e855b7a

…es. (flutter#20385)" (flutter#20936)" This reverts commit 96efe39.

abrush21 mentioned this pull request Sep 23, 2020

Reland: Adds fuchsia node roles to accessibility bridge updat… #21367

Merged

12 tasks

chunhtai pushed a commit that referenced this pull request Sep 25, 2020

Revert "Revert "Adds fuchsia node roles to accessibility bridge updat…

de5f2b4

…es. (#20385)" (#20936)" (#21367) This reverts commit 96efe39.

Adds fuchsia node roles to accessibility bridge updates. #20385

Adds fuchsia node roles to accessibility bridge updates. #20385

Uh oh!

Conversation

abrush21 commented Aug 10, 2020

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

chunhtai commented Aug 11, 2020

Uh oh!

gaaclarke commented Aug 12, 2020

Uh oh!

chunhtai commented Aug 12, 2020

Uh oh!

abrush21 commented Aug 12, 2020

Uh oh!

abrush21 commented Aug 12, 2020

Uh oh!

gaaclarke commented Aug 12, 2020

Uh oh!

abrush21 commented Sep 1, 2020

Uh oh!

chunhtai Sep 1, 2020

Choose a reason for hiding this comment

Uh oh!

chunhtai Sep 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abrush21 Sep 1, 2020

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

flar commented Sep 2, 2020

Uh oh!

flar commented Sep 2, 2020

Uh oh!

flar commented Sep 2, 2020

Uh oh!

chunhtai commented Sep 2, 2020

Uh oh!

abrush21 commented Sep 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chunhtai Sep 1, 2020 •

edited

Loading